Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register missing codecs for supporting ethsecp256k1 algo #138

Merged

Conversation

zale144
Copy link
Contributor

@zale144 zale144 commented Sep 23, 2024

Description


Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@zale144 zale144 self-assigned this Sep 23, 2024
@zale144 zale144 marked this pull request as ready for review September 23, 2024 17:07
@zale144 zale144 requested a review from a team as a code owner September 23, 2024 17:07
@omritoptix omritoptix changed the title fix: register missing codecs fix: register missing codecs for supporting ethsecp256k1 algo Sep 25, 2024
app/encoding.go Outdated Show resolved Hide resolved
app/ante.go Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
@mtsitrin
Copy link
Contributor

Few things that require additional research/validation:

  • To support ledger with coin type 60 we need EIP712 support (at least for portal support)
  • Will WASM frontend libs still work as expected? with ledger as well?

@zale144 zale144 requested a review from mtsitrin September 27, 2024 14:37
Copy link

github-actions bot commented Oct 6, 2024

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label Oct 6, 2024
@zale144 zale144 marked this pull request as draft October 6, 2024 23:39
@github-actions github-actions bot removed the Stale label Oct 7, 2024
@zale144 zale144 marked this pull request as ready for review October 9, 2024 10:38
@omritoptix omritoptix merged commit 0f65b88 into main Oct 9, 2024
109 of 141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants